AO3-5701 AO3-6331 Reindex works and bookmarks when a collection's parent changes#5816
Open
Smuzzy-waiii wants to merge 2 commits into
Conversation
…ent changes Reindex works and bookmarks when collection parent changes Works and bookmarks index parent collection IDs in Elasticsearch. When a collection is added to or removed from a parent collection, associated Elasticsearch documents are not updated, causing stale collection search results. This change reindexes affected works and bookmarks whenever a collection's parent_id changes.
Author
|
@sarken Could you please set the tickets to In-Review/In-Progress as I don't have Jira perms yet? 😄 |
pmonfort
reviewed
May 22, 2026
Contributor
pmonfort
left a comment
pmonfort
left a comment
There was a problem hiding this comment.
Great work! Left a couple of comments.
| after_commit :reindex_associated_works_and_bookmarks, | ||
| if: :saved_change_to_parent_id? | ||
|
|
||
| def reindex_associated_works_and_bookmarks |
Contributor
There was a problem hiding this comment.
Could you add specs that verify works and bookmarks are enqueued for reindexing when parent_id changes?
Maybe something like:
let(:parent_collection) { create(:collection) }
let(:child) { create(:collection, parent: parent_collection) }
it "enqueues reindexing of works when parent_id changes" do
work = create(:work)
child.collection_items.create(item: work)
expect(IndexQueue).to receive(:enqueue_ids).with(Work, [work.id], :background)
allow(IndexQueue).to receive(:enqueue_ids).with(Bookmark, anything, :background)
child.update!(parent: nil)
end
Comment on lines
+474
to
+486
| items = all_items.pluck(:item_type, :item_id) | ||
|
|
||
| work_ids = [] | ||
| bookmark_ids = [] | ||
|
|
||
| items.each do |item_type, item_id| | ||
| case item_type | ||
| when "Work" | ||
| work_ids << item_id | ||
| when "Bookmark" | ||
| bookmark_ids << item_id | ||
| end | ||
| end |
Contributor
There was a problem hiding this comment.
This works great, maybe nitpick improvement could be
Suggested change
| items = all_items.pluck(:item_type, :item_id) | |
| work_ids = [] | |
| bookmark_ids = [] | |
| items.each do |item_type, item_id| | |
| case item_type | |
| when "Work" | |
| work_ids << item_id | |
| when "Bookmark" | |
| bookmark_ids << item_id | |
| end | |
| end | |
| work_ids = all_items.where(item_type: "Work").pluck(:item_id).uniq | |
| bookmark_ids = all_items.where(item_type: "Bookmark").pluck(:item_id).uniq |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-5701
https://otwarchive.atlassian.net/browse/AO3-6331
Purpose
Reindex works and bookmarks when collection parent changes
Works and bookmarks index parent collection IDs in Elasticsearch. When a collection is added to or removed from a parent collection, associated Elasticsearch documents are not updated, causing stale collection search results.
This change reindexes affected works and bookmarks whenever a collection's parent_id changes.
Credit
Smaran Jawalkar (he/him)